MarkAHershberger has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62605
Change subject: Monobook: Remove unused file FF2Fixes.css
......................................................................
Monobook: Remove unused file FF2Fixes.css
As of Id8214c6a5 and Ia54dd738b (per bug 35906) we started
blacklisting Firefox 2 from the additional resource loader.
Though we haven't supported Firefox 2 for several years, Monobook
has had this patch for years and we never removed it (cheap to
maintain).
Since wikibits.js is no longer being loaded in Firefox 2, this
fix is now obsolete. It is never loaded, not even in Firefox 2.
It is causing problems because the legacy code incorrectly
detects Firefox 20 as Firefox 2, so instead of being a useless
file that is never loaded, it is actually causing problems by
being loaded in Firefox 20.
Conflicts:
RELEASE-NOTES-1.21
Bug: 47202
Change-Id: I2fdd0da8c17553a3465ef27c46a4632e135c4405
---
M RELEASE-NOTES-1.20
M skins/common/wikibits.js
D skins/monobook/FF2Fixes.css
3 files changed, 1 insertion(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/05/62605/1
diff --git a/RELEASE-NOTES-1.20 b/RELEASE-NOTES-1.20
index ac9dbd3..f155442 100644
--- a/RELEASE-NOTES-1.20
+++ b/RELEASE-NOTES-1.20
@@ -151,6 +151,7 @@
uploads.
* (bug 40448) mediawiki.legacy.mwsuggest has been replaced with a new module,
mediawiki.searchSuggest, based on SimpleSeach from Extension:Vector.
+* (bug 47202) wikibits: FF2Fixes.css should not be loaded in Firefox 20.
=== Bug fixes in 1.20 ===
* (bug 30245) Use the correct way to construct a log page title.
diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js
index cae08af..05efb4a 100644
--- a/skins/common/wikibits.js
+++ b/skins/common/wikibits.js
@@ -123,8 +123,6 @@
importStylesheetURI( skinpath + '/Opera7Fixes.css' );
} else if ( opera95_bugs ) {
importStylesheetURI( skinpath + '/Opera9Fixes.css' );
- } else if ( ff2_bugs ) {
- importStylesheetURI( skinpath + '/FF2Fixes.css' );
}
}
diff --git a/skins/monobook/FF2Fixes.css b/skins/monobook/FF2Fixes.css
deleted file mode 100644
index c8b65f5..0000000
--- a/skins/monobook/FF2Fixes.css
+++ /dev/null
@@ -1,4 +0,0 @@
-.rtl .external, a.feedlink {
- padding: 0 !important;
- background: none !important;
-}
--
To view, visit https://gerrit.wikimedia.org/r/62605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fdd0da8c17553a3465ef27c46a4632e135c4405
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_20
Gerrit-Owner: MarkAHershberger <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
