jenkins-bot has submitted this change and it was merged.
Change subject: Monobook: Remove unused file FF2Fixes.css
......................................................................
Monobook: Remove unused file FF2Fixes.css
As of Id8214c6a5 and Ia54dd738b (per bug 35906) we started
blacklisting Firefox 2 from the additional resource loader.
Though we haven't supported Firefox 2 for several years, Monobook
has had this patch for years and we never removed it (cheap to
maintain).
Since wikibits.js is no longer being loaded in Firefox 2, this
fix is now obsolete. It is never loaded, not even in Firefox 2.
It is causing problems because the legacy code incorrectly
detects Firefox 20 as Firefox 2, so instead of being a useless
file that is never loaded, it is actually causing problems by
being loaded in Firefox 20.
Bug: 47202
Change-Id: I2fdd0da8c17553a3465ef27c46a4632e135c4405
---
M RELEASE-NOTES-1.20
M skins/common/wikibits.js
D skins/monobook/FF2Fixes.css
3 files changed, 9 insertions(+), 6 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/RELEASE-NOTES-1.20 b/RELEASE-NOTES-1.20
index 80b200d..2da9e35 100644
--- a/RELEASE-NOTES-1.20
+++ b/RELEASE-NOTES-1.20
@@ -3,6 +3,15 @@
Security reminder: MediaWiki does not require PHP's register_globals
setting since version 1.2.0. If you have it on, turn it '''off''' if you can.
+
+== MediaWiki 1.20.6 ==
+
+This is a maintenance release of the MediaWiki 1.20 branch.
+
+=== Changes since 1.20.5 ===
+* (bug 47202) wikibits: FF2Fixes.css should not be loaded in Firefox 20.
+
+
== MediaWiki 1.20.5 ==
This is a security and maintenance release of the MediaWiki 1.20 branch.
diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js
index cae08af..05efb4a 100644
--- a/skins/common/wikibits.js
+++ b/skins/common/wikibits.js
@@ -123,8 +123,6 @@
importStylesheetURI( skinpath + '/Opera7Fixes.css' );
} else if ( opera95_bugs ) {
importStylesheetURI( skinpath + '/Opera9Fixes.css' );
- } else if ( ff2_bugs ) {
- importStylesheetURI( skinpath + '/FF2Fixes.css' );
}
}
diff --git a/skins/monobook/FF2Fixes.css b/skins/monobook/FF2Fixes.css
deleted file mode 100644
index c8b65f5..0000000
--- a/skins/monobook/FF2Fixes.css
+++ /dev/null
@@ -1,4 +0,0 @@
-.rtl .external, a.feedlink {
- padding: 0 !important;
- background: none !important;
-}
--
To view, visit https://gerrit.wikimedia.org/r/62605
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fdd0da8c17553a3465ef27c46a4632e135c4405
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_20
Gerrit-Owner: MarkAHershberger <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
