Robmoen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63241
Change subject: Fix check for existing category in article.
......................................................................
Fix check for existing category in article.
Now looking inside existingCategories array for category string vs
item object. When adding side by side duplicate categories,
category is now in correct section of menu.
Change-Id: I40dd30d80fb8bf818c077512468d630a5cb84120
---
M modules/ve/ui/widgets/ve.ui.MWCategoryInputWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/41/63241/1
diff --git a/modules/ve/ui/widgets/ve.ui.MWCategoryInputWidget.js
b/modules/ve/ui/widgets/ve.ui.MWCategoryInputWidget.js
index e7cbbf5..f54f0b3 100644
--- a/modules/ve/ui/widgets/ve.ui.MWCategoryInputWidget.js
+++ b/modules/ve/ui/widgets/ve.ui.MWCategoryInputWidget.js
@@ -116,7 +116,7 @@
for ( i = 0, len = matchingCategories.length; i < len; i++ ) {
item = matchingCategories[i];
if (
- existingCategoryItems.indexOf( item ) === -1 &&
+ existingCategoryItems.indexOf( category.value ) === -1
&&
item.match( pattern )
) {
if ( item === category.value ) {
--
To view, visit https://gerrit.wikimedia.org/r/63241
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I40dd30d80fb8bf818c077512468d630a5cb84120
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
