jenkins-bot has submitted this change and it was merged.
Change subject: Fix check for existing category in article.
......................................................................
Fix check for existing category in article.
Now looking inside existingCategories array for category string vs
item object. When adding side by side duplicate categories,
category is now in correct section of menu.
Change-Id: I40dd30d80fb8bf818c077512468d630a5cb84120
---
M modules/ve/ui/widgets/ve.ui.MWCategoryInputWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
Objections:
Catrope: There's a problem with this change, please improve
diff --git a/modules/ve/ui/widgets/ve.ui.MWCategoryInputWidget.js
b/modules/ve/ui/widgets/ve.ui.MWCategoryInputWidget.js
index e7cbbf5..f54f0b3 100644
--- a/modules/ve/ui/widgets/ve.ui.MWCategoryInputWidget.js
+++ b/modules/ve/ui/widgets/ve.ui.MWCategoryInputWidget.js
@@ -116,7 +116,7 @@
for ( i = 0, len = matchingCategories.length; i < len; i++ ) {
item = matchingCategories[i];
if (
- existingCategoryItems.indexOf( item ) === -1 &&
+ existingCategoryItems.indexOf( category.value ) === -1
&&
item.match( pattern )
) {
if ( item === category.value ) {
--
To view, visit https://gerrit.wikimedia.org/r/63241
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40dd30d80fb8bf818c077512468d630a5cb84120
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
