Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65293


Change subject: Added tests for PropertyValueSortExpression
......................................................................

Added tests for PropertyValueSortExpression

Change-Id: Id4e89324f2c8852b6e2810b7bac3de2e272fa936
---
M Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Ask 
refs/changes/93/65293/1

diff --git a/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php 
b/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php
index b2c559d..71b1ba3 100644
--- a/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php
+++ b/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php
@@ -37,6 +37,26 @@
  */
 class PropertyValueSortExpressionTest extends SortExpressionTest {
 
+       public function testCanConstruct() {
+               new PropertyValueSortExpression(
+                       new StringValue( 'foo' ),
+                       SortExpression::ASCENDING
+               );
+
+               $this->assertTrue( true );
+       }
+
+       public function testGetPropertyId() {
+               $propertyId = new StringValue( 'foo' );
+
+               $sortExpression = new PropertyValueSortExpression(
+                       $propertyId,
+                       SortExpression::ASCENDING
+               );
+
+               $this->assertEquals( $propertyId, 
$sortExpression->getPropertyId() );
+       }
+
        /**
         * @see SortExpressionTest::getInstances
         *

-- 
To view, visit https://gerrit.wikimedia.org/r/65293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4e89324f2c8852b6e2810b7bac3de2e272fa936
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Ask
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to