jenkins-bot has submitted this change and it was merged.
Change subject: Added tests for PropertyValueSortExpression
......................................................................
Added tests for PropertyValueSortExpression
Change-Id: Id4e89324f2c8852b6e2810b7bac3de2e272fa936
---
M Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php
1 file changed, 20 insertions(+), 0 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php
b/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php
index b2c559d..71b1ba3 100644
--- a/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php
+++ b/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php
@@ -37,6 +37,26 @@
*/
class PropertyValueSortExpressionTest extends SortExpressionTest {
+ public function testCanConstruct() {
+ new PropertyValueSortExpression(
+ new StringValue( 'foo' ),
+ SortExpression::ASCENDING
+ );
+
+ $this->assertTrue( true );
+ }
+
+ public function testGetPropertyId() {
+ $propertyId = new StringValue( 'foo' );
+
+ $sortExpression = new PropertyValueSortExpression(
+ $propertyId,
+ SortExpression::ASCENDING
+ );
+
+ $this->assertEquals( $propertyId,
$sortExpression->getPropertyId() );
+ }
+
/**
* @see SortExpressionTest::getInstances
*
--
To view, visit https://gerrit.wikimedia.org/r/65293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4e89324f2c8852b6e2810b7bac3de2e272fa936
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Ask
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Anja Jentzsch <[email protected]>
Gerrit-Reviewer: Ataherivand <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: Denny Vrandecic <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: Jens Ohlig <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: John Erling Blad <[email protected]>
Gerrit-Reviewer: Lydia Pintscher <[email protected]>
Gerrit-Reviewer: Markus Kroetzsch <[email protected]>
Gerrit-Reviewer: Nikola Smolenski <[email protected]>
Gerrit-Reviewer: Silke Meyer <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
