jenkins-bot has submitted this change and it was merged. Change subject: Move zero banner to Zero extension ......................................................................
Move zero banner to Zero extension Make use of onMinervaPreRender hook (depends on https://gerrit.wikimedia.org/r/64608) Change-Id: I3f3d59f7c248fe6d4098f417bea75d2319d1031e --- M includes/skins/SkinMobileBase.php 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Dr0ptp4kt: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/skins/SkinMobileBase.php b/includes/skins/SkinMobileBase.php index 8069d50..b166ec3 100644 --- a/includes/skins/SkinMobileBase.php +++ b/includes/skins/SkinMobileBase.php @@ -25,13 +25,6 @@ } $tpl->set( '_show_menu_headers', $menuHeaders ); $tpl->set( 'searchBox', $search ); - - $banners = $tpl->data['banners']; - // FIXME: Move to Zero extension MinervaPreRender hook - if ( isset( $tpl->data['zeroRatedBanner'] ) ) { - $banners[] = $tpl->data['zeroRatedBanner']; - } - $tpl->set( 'banners', $banners ); if ( $inBeta ) { $this->prepareDataBeta( $tpl ); } -- To view, visit https://gerrit.wikimedia.org/r/65135 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f3d59f7c248fe6d4098f417bea75d2319d1031e Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> Gerrit-Reviewer: Dr0ptp4kt <[email protected]> Gerrit-Reviewer: Yurik <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
