Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/65135
Change subject: Move zero banner to Zero extension ...................................................................... Move zero banner to Zero extension Make use of onMinervaPreRender hook (depends on https://gerrit.wikimedia.org/r/64608) Whilst here identify other zero code that needs to move out of MobileFrontend Change-Id: I3f3d59f7c248fe6d4098f417bea75d2319d1031e --- M includes/skins/MinervaTemplate.php 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/35/65135/1 diff --git a/includes/skins/MinervaTemplate.php b/includes/skins/MinervaTemplate.php index 3f85005..9639447 100644 --- a/includes/skins/MinervaTemplate.php +++ b/includes/skins/MinervaTemplate.php @@ -46,9 +46,6 @@ private function prepareBannerData() { global $wgMFEnableSiteNotice; $banners = ''; - if ( isset( $this->data['zeroRatedBanner'] ) ) { // FIXME: Add hook and move to Zero extension? - $banners .= $this->data['zeroRatedBanner']; - } if ( isset( $this->data['notice'] ) ) { $banners .= $this->data['notice']; } -- To view, visit https://gerrit.wikimedia.org/r/65135 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3f3d59f7c248fe6d4098f417bea75d2319d1031e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
