Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/67443


Change subject: Move initializaton of $session_id from after to before block
......................................................................

Move initializaton of $session_id from after to before block

This should solve the problem of Jenkins jobs pointing to wrong Sauce
jobs, or Jenkins jobs having http://saucelabs.com/jobs/ link

Bug: 46888
Change-Id: I976e35cbc970fa15be667a0e4b47840ae552b371
---
M features/support/env.rb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/43/67443/1

diff --git a/features/support/env.rb b/features/support/env.rb
index 779098e..fb28383 100644
--- a/features/support/env.rb
+++ b/features/support/env.rb
@@ -119,6 +119,7 @@
 end
 
 Before do |scenario|
+  $session_id = @browser.driver.session_id
   @config = config
   @does_not_exist_page_name = Random.new.rand.to_s
   @mediawiki_username = mediawiki_username
@@ -127,7 +128,6 @@
 end
 
 After do |scenario|
-  $session_id = @browser.driver.instance_variable_get(:@bridge).session_id
   if environment == :cloudbees
     sauce_api(%Q{{"passed": #{scenario.passed?}}}, saucelabs_username, 
saucelabs_key)
     sauce_api(%Q{{"public": true}}, saucelabs_username, saucelabs_key)

-- 
To view, visit https://gerrit.wikimedia.org/r/67443
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I976e35cbc970fa15be667a0e4b47840ae552b371
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to