Cmcmahon has submitted this change and it was merged. Change subject: Move initializaton of $session_id from after to before block ......................................................................
Move initializaton of $session_id from after to before block This should solve the problem of Jenkins jobs pointing to wrong Sauce jobs, or Jenkins jobs having http://saucelabs.com/jobs/ link Bug: 46888 Change-Id: I976e35cbc970fa15be667a0e4b47840ae552b371 --- M features/support/env.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Cmcmahon: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/features/support/env.rb b/features/support/env.rb index 779098e..26e8562 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -124,10 +124,10 @@ @mediawiki_username = mediawiki_username @mediawiki_password = mediawiki_password @browser = browser(environment, test_name(scenario), saucelabs_username, saucelabs_key, 'default') unless @language + $session_id = @browser.driver.instance_variable_get(:@bridge).session_id end After do |scenario| - $session_id = @browser.driver.instance_variable_get(:@bridge).session_id if environment == :cloudbees sauce_api(%Q{{"passed": #{scenario.passed?}}}, saucelabs_username, saucelabs_key) sauce_api(%Q{{"public": true}}, saucelabs_username, saucelabs_key) -- To view, visit https://gerrit.wikimedia.org/r/67443 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I976e35cbc970fa15be667a0e4b47840ae552b371 Gerrit-PatchSet: 2 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Zfilipin <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: Rachel99 <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
