Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/67974
Change subject: Don't try to filter uploads with an invalid title
......................................................................
Don't try to filter uploads with an invalid title
This was causing fatals and is pointless anyway as
these uploads will never succeed.
Bug: 49399
Change-Id: Ifb16afe3e02854b8f53eb8dae87e13de669381ab
---
M AbuseFilter.hooks.php
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter
refs/changes/74/67974/1
diff --git a/AbuseFilter.hooks.php b/AbuseFilter.hooks.php
index 27f35e6..96b421c 100644
--- a/AbuseFilter.hooks.php
+++ b/AbuseFilter.hooks.php
@@ -506,6 +506,13 @@
$vars = new AbuseFilterVariableHolder;
$title = $upload->getTitle();
+
+ if ( !$title ) {
+ // If there's no valid title assigned to the upload
+ // it wont proceed anyway, so no point in filtering it.
+ return true;
+ }
+
$vars->addHolders(
AbuseFilter::generateUserVars( $wgUser ),
AbuseFilter::generateTitleVars( $title, 'FILE' )
--
To view, visit https://gerrit.wikimedia.org/r/67974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb16afe3e02854b8f53eb8dae87e13de669381ab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
