jenkins-bot has submitted this change and it was merged. Change subject: Don't try to filter uploads with an invalid title ......................................................................
Don't try to filter uploads with an invalid title This was causing fatals and is pointless anyway as these uploads will never succeed. Bug: 49399 Change-Id: Ifb16afe3e02854b8f53eb8dae87e13de669381ab --- M AbuseFilter.hooks.php 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: CSteipp: Looks good to me, approved jenkins-bot: Verified diff --git a/AbuseFilter.hooks.php b/AbuseFilter.hooks.php index 27f35e6..96b421c 100644 --- a/AbuseFilter.hooks.php +++ b/AbuseFilter.hooks.php @@ -506,6 +506,13 @@ $vars = new AbuseFilterVariableHolder; $title = $upload->getTitle(); + + if ( !$title ) { + // If there's no valid title assigned to the upload + // it wont proceed anyway, so no point in filtering it. + return true; + } + $vars->addHolders( AbuseFilter::generateUserVars( $wgUser ), AbuseFilter::generateTitleVars( $title, 'FILE' ) -- To view, visit https://gerrit.wikimedia.org/r/67974 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb16afe3e02854b8f53eb8dae87e13de669381ab Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/AbuseFilter Gerrit-Branch: master Gerrit-Owner: Hoo man <h...@online.de> Gerrit-Reviewer: CSteipp <cste...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits