Mattflaschen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/70327


Change subject: Don't log when schemaAction is falsy.
......................................................................

Don't log when schemaAction is falsy.

Bug: 50065
Change-Id: I329f5992900945535fbd5431eb53f13ecddb9e4b
---
M resources/ext.gettingstarted.openTask.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted 
refs/changes/27/70327/1

diff --git a/resources/ext.gettingstarted.openTask.js 
b/resources/ext.gettingstarted.openTask.js
index 9e09ffb..29e2f5a 100644
--- a/resources/ext.gettingstarted.openTask.js
+++ b/resources/ext.gettingstarted.openTask.js
@@ -8,7 +8,9 @@
        task = logging.getTaskForCurrentPage();
        schemaAction = logging.getPageSchemaAction();
 
-       if ( !task ) {
+       // No task or no schema.
+       // Expected to be task but not schemaAction in cases such as the 
history view.
+       if ( !task || !schemaAction) {
                return;
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/70327
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I329f5992900945535fbd5431eb53f13ecddb9e4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to