jenkins-bot has submitted this change and it was merged.
Change subject: Don't log when schemaAction is falsy.
......................................................................
Don't log when schemaAction is falsy.
Bug: 50065
Change-Id: I329f5992900945535fbd5431eb53f13ecddb9e4b
---
M resources/ext.gettingstarted.openTask.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.gettingstarted.openTask.js
b/resources/ext.gettingstarted.openTask.js
index 9e09ffb..29e2f5a 100644
--- a/resources/ext.gettingstarted.openTask.js
+++ b/resources/ext.gettingstarted.openTask.js
@@ -8,7 +8,9 @@
task = logging.getTaskForCurrentPage();
schemaAction = logging.getPageSchemaAction();
- if ( !task ) {
+ // No task or no schema.
+ // Expected to be task but not schemaAction in cases such as the
history view.
+ if ( !task || !schemaAction) {
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/70327
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I329f5992900945535fbd5431eb53f13ecddb9e4b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
