Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70735
Change subject: mw.ViewPageTarget: Don't handle edt tab clicks from special
mouse buttons
......................................................................
mw.ViewPageTarget: Don't handle edt tab clicks from special mouse buttons
Regular mouse button click is normalised to which=1 by jQuery.
Change-Id: I08a711d8251613144ba6b463d4d240aedd98bb2a
---
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/35/70735/1
diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index 3c10afa..125356f 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -555,10 +555,13 @@
* @param {jQuery.Event} e Mouse click event
*/
ve.init.mw.ViewPageTarget.prototype.onEditTabClick = function ( e ) {
- this.logEvent( 'Edit', { action: 'edit-link-click' } );
- this.activate();
- // Prevent the edit tab's normal behavior
- e.preventDefault();
+ // Only do our handling if no keyboard or mouse buttons are used
+ if ( !e.which || e.which === 1 ) {
+ this.logEvent( 'Edit', { action: 'edit-link-click' } );
+ this.activate();
+ // Prevent the edit tab's normal behavior
+ e.preventDefault();
+ }
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/70735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08a711d8251613144ba6b463d4d240aedd98bb2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
