Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/70774
Change subject: mw.ViewPageTarget: Don't handle edt tab clicks from special
mouse buttons
......................................................................
mw.ViewPageTarget: Don't handle edt tab clicks from special mouse buttons
Regular mouse button click is normalised to which=1 by jQuery.
Change-Id: I028b988d66e66b29b04d2c65668b4aadb568558e
---
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/74/70774/1
diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index 6a89659..7f3557b 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -559,7 +559,7 @@
// Only do our handling if no keys are pressed, mouse button is 1
// (e.g. not middle click or right click) and no modifier keys
// (e.g. cmd-click to open in new tab).
- if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.altKey ||
e.metaKey ) {
+ if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.ctrlKey ||
e.altKey || e.metaKey ) {
return;
}
this.logEvent( 'Edit', { action: 'edit-link-click' } );
@@ -575,7 +575,7 @@
* @param {jQuery.Event} e Mouse click event
*/
ve.init.mw.ViewPageTarget.prototype.onEditSectionLinkClick = function ( e ) {
- if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.altKey ||
e.metaKey ) {
+ if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.ctrlKey ||
e.altKey || e.metaKey ) {
return;
}
this.logEvent( 'Edit', { action: 'section-edit-link-click' } );
@@ -592,7 +592,7 @@
* @param {jQuery.Event} e Mouse click event
*/
ve.init.mw.ViewPageTarget.prototype.onViewTabClick = function ( e ) {
- if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.altKey ||
e.metaKey ) {
+ if ( ( e.which && e.which !== 1 ) || e.shiftKey || e.ctrlKey ||
e.altKey || e.metaKey ) {
return;
}
if ( this.active ) {
--
To view, visit https://gerrit.wikimedia.org/r/70774
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I028b988d66e66b29b04d2c65668b4aadb568558e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
