GWicke has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/70909


Change subject: Add a space if the key ends on a space, even if the value is 
empty
......................................................................

Add a space if the key ends on a space, even if the value is empty

RT testing showed that this variant is more common, even if the value is
actually empty. Follow the data.

Change-Id: Ic694de7967ef8ae31880229f2e0d2d021694ec23
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/09/70909/1

diff --git a/js/lib/mediawiki.WikitextSerializer.js 
b/js/lib/mediawiki.WikitextSerializer.js
index 03f0e60..6a4d419 100644
--- a/js/lib/mediawiki.WikitextSerializer.js
+++ b/js/lib/mediawiki.WikitextSerializer.js
@@ -2701,7 +2701,7 @@
                                                                        if 
(vStr && !/^\s/.test(v)) {
                                                                                
vStr = ' ' + vStr;
                                                                        }
-                                                               } else if 
(k.match(/\s$/) && vStr && !v.match(/^\s/)) {
+                                                               } else if 
(/\s$/.test(k) && !/^\s/.test(vStr)) {
                                                                        // Only 
prefix value with space if key
                                                                        // ends 
with space too
                                                                        vStr = 
' ' + vStr;

-- 
To view, visit https://gerrit.wikimedia.org/r/70909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic694de7967ef8ae31880229f2e0d2d021694ec23
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to