jenkins-bot has submitted this change and it was merged.
Change subject: Add a space if the key ends on a space, even if the value is
empty
......................................................................
Add a space if the key ends on a space, even if the value is empty
RT testing showed that this variant is more common, even if the value is
actually empty. Follow the data.
Change-Id: Ic694de7967ef8ae31880229f2e0d2d021694ec23
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/mediawiki.WikitextSerializer.js
b/js/lib/mediawiki.WikitextSerializer.js
index 4511da9..28b8120 100644
--- a/js/lib/mediawiki.WikitextSerializer.js
+++ b/js/lib/mediawiki.WikitextSerializer.js
@@ -2725,7 +2725,7 @@
if
(vStr && !/^\s/.test(v)) {
vStr = ' ' + vStr;
}
- } else if
(k.match(/\s$/) && vStr && !v.match(/^\s/)) {
+ } else if
(/\s$/.test(k) && !/^\s/.test(vStr)) {
// Only
prefix value with space if key
// ends
with space too
vStr =
' ' + vStr;
--
To view, visit https://gerrit.wikimedia.org/r/70909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic694de7967ef8ae31880229f2e0d2d021694ec23
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
