Cmcmahon has submitted this change and it was merged.

Change subject: Run "Open Language selector" scenario at test2
......................................................................


Run "Open Language selector" scenario at test2

Bug: 48831
Change-Id: I0e01701f8a23ee4e52cc39d0222ba2deada208c7
---
M features/step_definitions/uls_steps.rb
M features/support/pages/random_page.rb
M features/uls.feature
3 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Cmcmahon: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/features/step_definitions/uls_steps.rb 
b/features/step_definitions/uls_steps.rb
index 28af60f7..cb3372a 100644
--- a/features/step_definitions/uls_steps.rb
+++ b/features/step_definitions/uls_steps.rb
@@ -3,7 +3,7 @@
 end
 
 Then(/^I should see the Language selector$/) do
-  on(RandomPage).search_element.should exist
+  on(RandomPage).language_settings_dialog_element.should be_visible
 end
 
 Then(/^I should see a cog icon near the 'Languages' header$/) do
diff --git a/features/support/pages/random_page.rb 
b/features/support/pages/random_page.rb
index 44c0c93..7e8b030 100644
--- a/features/support/pages/random_page.rb
+++ b/features/support/pages/random_page.rb
@@ -11,10 +11,10 @@
   div(:input_method, class: 'imeselector imeselector-toggle')
   ul(:input_method_language_list, class: 'ime-language-list')
   div(:input_method_selector_menu, class: 'imeselector-menu')
+  div(:language_settings_dialog, id: 'language-settings-dialog')
   li(:main_page, id: 'n-mainpage-description')
   a(:print_export, text: 'Print/export')
   a(:printable_version, text: 'Printable version')
-  div(:search, id: 'search')
   button(:search_button, id: 'searchButton')
   text_field(:search_input, id: 'searchInput')
   a(:uls_trigger, class: 'uls-trigger')
diff --git a/features/uls.feature b/features/uls.feature
index f9bfe39..42e7888 100644
--- a/features/uls.feature
+++ b/features/uls.feature
@@ -1,6 +1,7 @@
 @sandbox.translatewiki.net
 Feature: Universal Language Selector User language selector
 
+  @test2.wikipedia.org
   Scenario: Open Language selector
     Given I visit a random page
     When I click language selector trigger element

-- 
To view, visit https://gerrit.wikimedia.org/r/71646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e01701f8a23ee4e52cc39d0222ba2deada208c7
Gerrit-PatchSet: 3
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Rachel99 <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to