MaxSem has uploaded a new change for review.
https://gerrit.wikimedia.org/r/74637
Change subject: Minor cleanup: unused vars, annotations
......................................................................
Minor cleanup: unused vars, annotations
Change-Id: I750bdb11d25a6b79aab3676c3e6b9f420378bdec
---
M includes/api/ApiQueryExtracts.php
M includes/skins/SkinMobile.php
M includes/skins/SkinMobileAlpha.php
M includes/specials/SpecialMobileDiff.php
4 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/37/74637/1
diff --git a/includes/api/ApiQueryExtracts.php
b/includes/api/ApiQueryExtracts.php
index fe04e19..8c3085b 100644
--- a/includes/api/ApiQueryExtracts.php
+++ b/includes/api/ApiQueryExtracts.php
@@ -36,6 +36,7 @@
$titles = array_slice( $titles, $continue, null, true );
}
$count = 0;
+ /** @var Title $t */
foreach ( $titles as $id => $t ) {
if ( ++$count > $limit ) {
$this->setContinueEnumParameter( 'continue',
$continue + $count - 1 );
diff --git a/includes/skins/SkinMobile.php b/includes/skins/SkinMobile.php
index 6ccd6a8..35897b4 100644
--- a/includes/skins/SkinMobile.php
+++ b/includes/skins/SkinMobile.php
@@ -46,7 +46,6 @@
$tpl = $this->prepareTemplate();
$tpl->set( 'headelement', $out->headElement( $this ) );
$tpl->set( 'bodytext', $html );
- $notice = '';
$tpl->set( 'reporttime', wfReportTime() );
$tpl->execute();
wfProfileOut( __METHOD__ . '-tpl' );
diff --git a/includes/skins/SkinMobileAlpha.php
b/includes/skins/SkinMobileAlpha.php
index d51fde9..31343f1 100644
--- a/includes/skins/SkinMobileAlpha.php
+++ b/includes/skins/SkinMobileAlpha.php
@@ -36,7 +36,6 @@
protected function prepareTalkLabel( BaseTemplate $tpl ) {
$title = $this->getTitle();
- $user = $this->getUser();
$isSpecialPage = $title->isSpecialPage();
// talk page link for logged in alpha users
diff --git a/includes/specials/SpecialMobileDiff.php
b/includes/specials/SpecialMobileDiff.php
index d403175..1d90e1a 100644
--- a/includes/specials/SpecialMobileDiff.php
+++ b/includes/specials/SpecialMobileDiff.php
@@ -76,7 +76,8 @@
$prev = $revisions[0];
if ( is_null( $rev ) ) {
- return $this->executeBadQuery();
+ $this->executeBadQuery();
+ return;
}
$this->revId = $rev->getId();
$this->rev = $rev;
@@ -96,7 +97,6 @@
$this->showFooter();
$output->addHtml( '</div>' );
- return true;
}
function showHeader() {
--
To view, visit https://gerrit.wikimedia.org/r/74637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I750bdb11d25a6b79aab3676c3e6b9f420378bdec
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
