jenkins-bot has submitted this change and it was merged.
Change subject: Minor cleanup: unused vars, annotations
......................................................................
Minor cleanup: unused vars, annotations
Change-Id: I750bdb11d25a6b79aab3676c3e6b9f420378bdec
---
M includes/api/ApiQueryExtracts.php
M includes/skins/SkinMobile.php
M includes/skins/SkinMobileAlpha.php
3 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/api/ApiQueryExtracts.php
b/includes/api/ApiQueryExtracts.php
index fe04e19..8c3085b 100644
--- a/includes/api/ApiQueryExtracts.php
+++ b/includes/api/ApiQueryExtracts.php
@@ -36,6 +36,7 @@
$titles = array_slice( $titles, $continue, null, true );
}
$count = 0;
+ /** @var Title $t */
foreach ( $titles as $id => $t ) {
if ( ++$count > $limit ) {
$this->setContinueEnumParameter( 'continue',
$continue + $count - 1 );
diff --git a/includes/skins/SkinMobile.php b/includes/skins/SkinMobile.php
index b8aba00..679b55a 100644
--- a/includes/skins/SkinMobile.php
+++ b/includes/skins/SkinMobile.php
@@ -47,7 +47,6 @@
$tpl = $this->prepareTemplate();
$tpl->set( 'headelement', $out->headElement( $this ) );
$tpl->set( 'bodytext', $html );
- $notice = '';
$tpl->set( 'reporttime', wfReportTime() );
$tpl->execute();
wfProfileOut( __METHOD__ . '-tpl' );
diff --git a/includes/skins/SkinMobileAlpha.php
b/includes/skins/SkinMobileAlpha.php
index d51fde9..31343f1 100644
--- a/includes/skins/SkinMobileAlpha.php
+++ b/includes/skins/SkinMobileAlpha.php
@@ -36,7 +36,6 @@
protected function prepareTalkLabel( BaseTemplate $tpl ) {
$title = $this->getTitle();
- $user = $this->getUser();
$isSpecialPage = $title->isSpecialPage();
// talk page link for logged in alpha users
--
To view, visit https://gerrit.wikimedia.org/r/74637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I750bdb11d25a6b79aab3676c3e6b9f420378bdec
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
