Mollywhite has submitted this change and it was merged.
Change subject: Bug 51257: Improve chapter dropdown for books with many
chapters.
......................................................................
Bug 51257: Improve chapter dropdown for books with many chapters.
Add scrollbar, limit height of the div
Change-Id: I1916d6d3df0b2e69b542b8e4ce4992da10c6797b
---
M BookManagerv2.hooks.php
M modules/ext.BookManagerv2js.css
2 files changed, 11 insertions(+), 2 deletions(-)
Approvals:
Mollywhite: Verified; Looks good to me, approved
Mwalker: Looks good to me, but someone else must approve
jenkins-bot: Checked
diff --git a/BookManagerv2.hooks.php b/BookManagerv2.hooks.php
index 69a32be..e424a3a 100644
--- a/BookManagerv2.hooks.php
+++ b/BookManagerv2.hooks.php
@@ -100,15 +100,20 @@
),
$metadata
);
- $html[] = Html::rawElement( 'div', array(
+ $html[] = Html::openElement( 'div', array(
'class' => array(
'mw-bookmanagerv2-nav-dropdown',
'mw-bookmanagerv2-nav-toc' )
- ),
+ )
+ );
+ $html[] = Html::rawElement( 'div', array(
+ 'class' => 'mw-bookmanagerv2-nav-scrollable'
+ ),
$chapterList
);
$html[] = Html::closeElement( 'div' );
$html[] = Html::closeElement( 'div' );
+ $html[] = Html::closeElement( 'div' );
return implode( $html );
}
diff --git a/modules/ext.BookManagerv2js.css b/modules/ext.BookManagerv2js.css
index 3938092..0635cf3 100644
--- a/modules/ext.BookManagerv2js.css
+++ b/modules/ext.BookManagerv2js.css
@@ -60,3 +60,7 @@
div.mw-bookmanagerv2-nav-dropdown .title {
font-style: italic;
}
+div.mw-bookmanagerv2-nav-scrollable {
+ max-height: 300px;
+ overflow: auto;
+}
--
To view, visit https://gerrit.wikimedia.org/r/74658
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1916d6d3df0b2e69b542b8e4ce4992da10c6797b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/BookManagerv2
Gerrit-Branch: master
Gerrit-Owner: Mollywhite <[email protected]>
Gerrit-Reviewer: Mollywhite <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: Raylton P. Sousa <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
