Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/75648


Change subject: Only display edit notices if the page is reviewable
......................................................................

Only display edit notices if the page is reviewable

Fixes oversight in b280716f

Change-Id: Ic35001f83754f49e2a1022d92e44d0584566813c
---
M frontend/FlaggablePageView.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs 
refs/changes/48/75648/1

diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index 1eab296..7e3cee8 100644
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -915,7 +915,7 @@
                // HACK: EditPage invokes addToEditView() before this function, 
so $this->noticesDone
                // will only be true if we're being called by EditPage, in 
which case we need to do nothing
                // to avoid duplicating the notices.
-               if ( $this->noticesDone ) {
+               if ( $this->noticesDone || !$this->article->isReviewable() ) {
                        return;
                }
                // HACK fake EditPage

-- 
To view, visit https://gerrit.wikimedia.org/r/75648
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic35001f83754f49e2a1022d92e44d0584566813c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to