Catrope has submitted this change and it was merged.
Change subject: Only display edit notices if the page is reviewable
......................................................................
Only display edit notices if the page is reviewable
Fixes oversight in b280716f
Change-Id: Ic35001f83754f49e2a1022d92e44d0584566813c
(cherry picked from commit 112d8175a369276141fe9d65594e0f864f9fdf71)
---
M frontend/FlaggablePageView.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Verified; Looks good to me, approved
diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index 06605f1..b84bbe3 100644
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -915,7 +915,7 @@
// HACK: EditPage invokes addToEditView() before this function,
so $this->noticesDone
// will only be true if we're being called by EditPage, in
which case we need to do nothing
// to avoid duplicating the notices.
- if ( $this->noticesDone ) {
+ if ( $this->noticesDone || !$this->article->isReviewable() ) {
return;
}
// HACK fake EditPage
--
To view, visit https://gerrit.wikimedia.org/r/75649
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic35001f83754f49e2a1022d92e44d0584566813c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: wmf/1.22wmf10
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
