Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/75849
Change subject: Treat not set parameter 'linktitle' as request to remove
sitelink
......................................................................
Treat not set parameter 'linktitle' as request to remove sitelink
* Remove a sitelink when the 'linktitle' parameter is not set or
is an empty string
Change-Id: Iaf608a43b1dd820b0fc81f51c17236f00cf7c6e4
---
M repo/includes/api/SetSiteLink.php
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/49/75849/1
diff --git a/repo/includes/api/SetSiteLink.php
b/repo/includes/api/SetSiteLink.php
index cb3beee..f0031ba 100644
--- a/repo/includes/api/SetSiteLink.php
+++ b/repo/includes/api/SetSiteLink.php
@@ -83,7 +83,10 @@
$item = $entityContent->getItem();
$linksite = $this->stringNormalizer->trimToNFC(
$params['linksite'] );
- if ( isset( $params['linksite'] ) && $params['linktitle'] ===
'' ) {
+ if (
+ isset( $params['linksite'] ) &&
+ ( is_null( $params['linktitle'] ) ||
$params['linktitle'] === '' ) )
+ {
if ( $item->hasLinkToSite( $linksite ) ) {
$link = $item->getSimpleSiteLink( $linksite );
$this->getChangeOp( $params )->apply( $item,
$summary );
@@ -107,7 +110,10 @@
*/
protected function getChangeOp( array $params ) {
wfProfileIn( __METHOD__ );
- if ( isset( $params['linksite'] ) && ( $params['linktitle'] ===
'' ) ) {
+ if (
+ isset( $params['linksite'] ) &&
+ ( is_null( $params['linktitle'] ) ||
$params['linktitle'] === '' ) )
+ {
$linksite = $this->stringNormalizer->trimToNFC(
$params['linksite'] );
wfProfileOut( __METHOD__ );
return new ChangeOpSiteLink( $linksite, null );
--
To view, visit https://gerrit.wikimedia.org/r/75849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf608a43b1dd820b0fc81f51c17236f00cf7c6e4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
