jenkins-bot has submitted this change and it was merged.
Change subject: Normalise error messages in JS
......................................................................
Normalise error messages in JS
Change-Id: I6bbbee2b4f6c01d158f147b3097618b3cffe475f
---
M modules/ext.codereview.loaddiff.js
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Reedy: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.codereview.loaddiff.js
b/modules/ext.codereview.loaddiff.js
index bcec999..54a2a28 100644
--- a/modules/ext.codereview.loaddiff.js
+++ b/modules/ext.codereview.loaddiff.js
@@ -26,7 +26,7 @@
if ( window.location.hostname === 'localhost' ) {
alert( 'Your browser blocks XMLHttpRequest to
"localhost", try using a real hostname for development/testing.' );
}
- CodeReview.setDiff( 'Diff load failed!' );
+ CodeReview.setDiff( 'Failed to load diff.' );
throw e;
}
},
@@ -34,7 +34,8 @@
if ( data && data.code && data.code.rev && data.code.rev.diff )
{
CodeReview.setDiff( data.code.rev.diff );
} else {
- CodeReview.setDiff( 'Diff load failed. :(' );
+ // Will occur when MediaWiki actually serves an error
back
+ CodeReview.setDiff( 'Failed to load diff. :(' );
}
},
diffTarget : function() {
@@ -45,4 +46,4 @@
}
});
-})( jQuery );
\ No newline at end of file
+})( jQuery );
--
To view, visit https://gerrit.wikimedia.org/r/78536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6bbbee2b4f6c01d158f147b3097618b3cffe475f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
