Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/79040
Change subject: Get rid of deprecated method in WikiPageEntityLookupTest
......................................................................
Get rid of deprecated method in WikiPageEntityLookupTest
Change-Id: I627423097c898f476be507bebdedd5f51e9d94f2
---
M lib/tests/phpunit/store/WikiPageEntityLookupTest.php
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/40/79040/1
diff --git a/lib/tests/phpunit/store/WikiPageEntityLookupTest.php
b/lib/tests/phpunit/store/WikiPageEntityLookupTest.php
index ec7e9eb..3ee65fb 100644
--- a/lib/tests/phpunit/store/WikiPageEntityLookupTest.php
+++ b/lib/tests/phpunit/store/WikiPageEntityLookupTest.php
@@ -7,6 +7,7 @@
use \Wikibase\EntityLookup;
use Wikibase\EntityRevision;
use \Wikibase\WikiPageEntityLookup;
+use Wikibase\Repo\WikibaseRepo;
/**
* Tests for the Wikibase\WikiPageEntityLookup class.
@@ -114,10 +115,14 @@
$lookup = $this->getLookup();
$entityRev = $lookup->getEntityRevision( $id, $revision );
+ $formatter =
WikibaseRepo::getDefaultInstance()->getEntityIdFormatter();
if ( $shouldExist ) {
$this->assertNotNull( $entityRev, "ID " .
$id->getPrefixedId() );
- $this->assertEquals( $id->getPrefixedId(),
$entityRev->getEntity()->getPrefixedId() );
+ $this->assertEquals(
+ $id->getPrefixedId(),
+ $formatter->format(
$entityRev->getEntity()->getId() )
+ );
if ( $revision > 0 ) {
$this->assertEquals( $revision,
$entityRev->getRevision() );
--
To view, visit https://gerrit.wikimedia.org/r/79040
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I627423097c898f476be507bebdedd5f51e9d94f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
