Jeroen De Dauw has submitted this change and it was merged.
Change subject: Get rid of deprecated method in WikiPageEntityLookupTest
......................................................................
Get rid of deprecated method in WikiPageEntityLookupTest
Change-Id: I627423097c898f476be507bebdedd5f51e9d94f2
---
M lib/tests/phpunit/store/WikiPageEntityLookupTest.php
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/tests/phpunit/store/WikiPageEntityLookupTest.php
b/lib/tests/phpunit/store/WikiPageEntityLookupTest.php
index ec7e9eb..060176e 100644
--- a/lib/tests/phpunit/store/WikiPageEntityLookupTest.php
+++ b/lib/tests/phpunit/store/WikiPageEntityLookupTest.php
@@ -116,14 +116,17 @@
$entityRev = $lookup->getEntityRevision( $id, $revision );
if ( $shouldExist ) {
- $this->assertNotNull( $entityRev, "ID " .
$id->getPrefixedId() );
- $this->assertEquals( $id->getPrefixedId(),
$entityRev->getEntity()->getPrefixedId() );
+ $this->assertNotNull( $entityRev, "ID " .
$id->__toString() );
+ $this->assertEquals(
+ $id,
+ $entityRev->getEntity()->getId()
+ );
if ( $revision > 0 ) {
$this->assertEquals( $revision,
$entityRev->getRevision() );
}
} else {
- $this->assertNull( $entityRev, "ID " .
$id->getPrefixedId() );
+ $this->assertNull( $entityRev, "ID " .
$id->__toString() );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/79040
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I627423097c898f476be507bebdedd5f51e9d94f2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
