Umherirrender has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/80406


Change subject: Add class around diff-empty and add it as notice
......................................................................

Add class around diff-empty and add it as notice

Add the moment the message is added within a class=diff-multi,
which is not true.

Bug: 53168
Follow-Up: I458fb688b0001fb674ece65b3fdabf56fc658a29
Change-Id: Ic3040ceca4ff1459181c84f041490e9e72b12802
---
M includes/diff/DifferenceEngine.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/06/80406/1

diff --git a/includes/diff/DifferenceEngine.php 
b/includes/diff/DifferenceEngine.php
index b102bfc..b80828b 100644
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -612,10 +612,10 @@
                        $multi = $this->getMultiNotice();
                        // Display a message when the diff is empty
                        if ( $body === '' ) {
-                               if ( $multi !== '' ) {
-                                       $multi .= '<br />';
+                               if ( $notice !== '' ) {
+                                       $notice .= '<br />';
                                }
-                               $multi .= $this->msg( 'diff-empty' )->parse();
+                               $notice .= '<div class="mw-diff-empty">' . 
$this->msg( 'diff-empty' )->parse() . "</div>\n";
                        }
                        return $this->addHeader( $body, $otitle, $ntitle, 
$multi, $notice );
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/80406
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3040ceca4ff1459181c84f041490e9e72b12802
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to