jenkins-bot has submitted this change and it was merged.
Change subject: Add class around diff-empty and add it as notice
......................................................................
Add class around diff-empty and add it as notice
Add the moment the message is added within a class=diff-multi,
which is not true.
Bug: 53168
Follow-Up: I458fb688b0001fb674ece65b3fdabf56fc658a29
Change-Id: Ic3040ceca4ff1459181c84f041490e9e72b12802
---
M includes/diff/DifferenceEngine.php
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Matmarex: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/diff/DifferenceEngine.php
b/includes/diff/DifferenceEngine.php
index b102bfc..5444bc1 100644
--- a/includes/diff/DifferenceEngine.php
+++ b/includes/diff/DifferenceEngine.php
@@ -612,10 +612,7 @@
$multi = $this->getMultiNotice();
// Display a message when the diff is empty
if ( $body === '' ) {
- if ( $multi !== '' ) {
- $multi .= '<br />';
- }
- $multi .= $this->msg( 'diff-empty' )->parse();
+ $notice .= '<div class="mw-diff-empty">' .
$this->msg( 'diff-empty' )->parse() . "</div>\n";
}
return $this->addHeader( $body, $otitle, $ntitle,
$multi, $notice );
}
--
To view, visit https://gerrit.wikimedia.org/r/80406
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3040ceca4ff1459181c84f041490e9e72b12802
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Fomafix
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Matmarex <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
