Addshore has submitted this change and it was merged.
Change subject: globe param cannot be null, update exception message
......................................................................
globe param cannot be null, update exception message
- per Denny, it is a required parameter
Change-Id: I80cac4a05e69427da1418a12ac6c2cc178145aff
---
M DataValues/src/GlobeCoordinateValue.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
Addshore: Verified
diff --git a/DataValues/src/GlobeCoordinateValue.php
b/DataValues/src/GlobeCoordinateValue.php
index 994ae07..cb03d47 100644
--- a/DataValues/src/GlobeCoordinateValue.php
+++ b/DataValues/src/GlobeCoordinateValue.php
@@ -72,7 +72,7 @@
protected function assertIsGlobe( $globe ) {
if ( !is_string( $globe ) ) {
- throw new IllegalValueException( 'Can only construct
GlobeCoordinateValue with a string or null globe parameter' );
+ throw new IllegalValueException( 'Can only construct
GlobeCoordinateValue with a string globe parameter' );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/80988
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80cac4a05e69427da1418a12ac6c2cc178145aff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
