Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/80991


Change subject: globe param cannot be null, update exception message
......................................................................

globe param cannot be null, update exception message

- per Denny, it is a required parameter

Change-Id: I80cac4a05e69427da1418a12ac6c2cc178145aff
---
M DataValues/src/GlobeCoordinateValue.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues 
refs/changes/91/80991/1

diff --git a/DataValues/src/GlobeCoordinateValue.php 
b/DataValues/src/GlobeCoordinateValue.php
index 994ae07..cb03d47 100644
--- a/DataValues/src/GlobeCoordinateValue.php
+++ b/DataValues/src/GlobeCoordinateValue.php
@@ -72,7 +72,7 @@
 
        protected function assertIsGlobe( $globe ) {
                if ( !is_string( $globe ) ) {
-                       throw new IllegalValueException( 'Can only construct 
GlobeCoordinateValue with a string or null globe parameter' );
+                       throw new IllegalValueException( 'Can only construct 
GlobeCoordinateValue with a string globe parameter' );
                }
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/80991
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I80cac4a05e69427da1418a12ac6c2cc178145aff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: mw1.22-wmf14
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to