Cmcmahon has submitted this change and it was merged.
Change subject: Cucumber runs tests, not Rake
......................................................................
Cucumber runs tests, not Rake
Bug: 49868
Change-Id: Ie7799f38c26ecbaf3709c1ba4ee7498b91402ef7
---
M Gemfile
M Gemfile.lock
M README.md
D Rakefile
M docs/job.md
5 files changed, 2 insertions(+), 22 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Gemfile b/Gemfile
index 3e7af91..56b4650 100755
--- a/Gemfile
+++ b/Gemfile
@@ -6,6 +6,5 @@
gem 'net-http-persistent'
gem 'page-object'
gem 'parallel_tests'
-gem 'rake'
gem 'rspec-expectations'
gem 'syntax'
diff --git a/Gemfile.lock b/Gemfile.lock
index 640c67f..52207c7 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -37,7 +37,6 @@
parallel (0.7.1)
parallel_tests (0.15.3)
parallel
- rake (10.1.0)
rspec-expectations (2.14.2)
diff-lcs (>= 1.1.3, < 2.0)
rubyzip (0.9.9)
@@ -63,6 +62,5 @@
net-http-persistent
page-object
parallel_tests
- rake
rspec-expectations
syntax
diff --git a/README.md b/README.md
index d92acab..335f910 100644
--- a/README.md
+++ b/README.md
@@ -16,7 +16,7 @@
mediawiki_password: password here
-Run the tests with `bundle exec rake`, this should start Firefox.
+Run the tests with `bundle exec cucumber`, this should start Firefox.
By default the tests run at en.wikipedia.beta.wmflabs.org. If you want to run
the tests elsewhere, you have to set `MEDIAWIKI_URL` environment variable. For
example:
diff --git a/Rakefile b/Rakefile
deleted file mode 100755
index 4f6f84f..0000000
--- a/Rakefile
+++ /dev/null
@@ -1,17 +0,0 @@
-desc 'Run serial task.'
-task default: :serial
-
-# cucumber needs this
-require 'cucumber/rake/task'
-Cucumber::Rake::Task.new(:serial, 'Run all Cucumber features in serial.') do
|t|
- t.profile = 'ci'
-end
-
-def processes
- FileList['./features/*.feature'].size
-end
-
-desc 'Run all Cucumber features in parallel.'
-task :parallel do
- sh "bundle exec parallel_cucumber features/ -n #{processes} --test-options
'--profile ci'"
-end
diff --git a/docs/job.md b/docs/job.md
index e5ca75f..5d9d7c1 100644
--- a/docs/job.md
+++ b/docs/job.md
@@ -22,7 +22,7 @@
gem install bundler --no-ri --no-rdoc
bundle install
- bundle exec rake
+ bundle exec cucumber
--
--
To view, visit https://gerrit.wikimedia.org/r/79783
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7799f38c26ecbaf3709c1ba4ee7498b91402ef7
Gerrit-PatchSet: 3
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Rachel99 <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
