[MediaWiki-commits] [Gerrit] Improvements to StatementTest - change (mediawiki...WikibaseDataModel)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/81948


Change subject: Improvements to StatementTest
......................................................................

Improvements to StatementTest

Change-Id: Ibd71dc39fcb097bfc8ca1f6462e7fff5ca27e2be
---
M tests/phpunit/Claim/StatementTest.php
1 file changed, 16 insertions(+), 13 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDataModel 
refs/changes/48/81948/1

diff --git a/tests/phpunit/Claim/StatementTest.php 
b/tests/phpunit/Claim/StatementTest.php
index dd8888f..127e6f1 100644
--- a/tests/phpunit/Claim/StatementTest.php
+++ b/tests/phpunit/Claim/StatementTest.php
@@ -4,7 +4,12 @@
 
 use DataValues\StringValue;
 use Wikibase\Claim;
+use Wikibase\DataModel\Entity\PropertyId;
+use Wikibase\PropertyNoValueSnak;
+use Wikibase\PropertyValueSnak;
 use Wikibase\Reference;
+use Wikibase\ReferenceList;
+use Wikibase\SnakList;
 use Wikibase\Statement;
 
 /**
@@ -28,9 +33,9 @@
        public function instanceProvider() {
                $instances = array();
 
-               $id42 = new \Wikibase\EntityId( 
\Wikibase\Property::ENTITY_TYPE, 42 );
+               $id42 = new PropertyId( 'P42' );
 
-               $baseInstance = new Statement( new 
\Wikibase\PropertyNoValueSnak( $id42 ) );
+               $baseInstance = new Statement( new PropertyNoValueSnak( $id42 ) 
);
 
                $instances[] = $baseInstance;
 
@@ -45,9 +50,9 @@
 
                $instance = clone $baseInstance;
 
-               $instance->setReferences( new \Wikibase\ReferenceList( array(
-                       new Reference( new \Wikibase\SnakList(
-                               new \Wikibase\PropertyValueSnak( new 
\Wikibase\EntityId( \Wikibase\Property::ENTITY_TYPE, 1 ), new StringValue( 'a' 
) )
+               $instance->setReferences( new ReferenceList( array(
+                       new Reference( new SnakList(
+                               new PropertyValueSnak( new PropertyId( 'P1' ), 
new StringValue( 'a' ) )
                        ) )
                ) ) );
 
@@ -73,10 +78,10 @@
         * @dataProvider instanceProvider
         */
        public function testSetReferences( Statement $statement ) {
-               $references = new \Wikibase\ReferenceList( array(
-                       new Reference( new \Wikibase\SnakList(
-                               new \Wikibase\PropertyValueSnak(
-                                       new \Wikibase\EntityId( 
\Wikibase\Property::ENTITY_TYPE, 1 ),
+               $references = new ReferenceList( array(
+                       new Reference( new SnakList(
+                               new PropertyValueSnak(
+                                       new PropertyId( 'P1' ),
                                        new StringValue( 'a' )
                                )
                        ) ) )
@@ -160,11 +165,11 @@
        }
 
        public function testGetHash() {
-               $claim0 = new Statement( new \Wikibase\PropertyNoValueSnak( 42 
) );
+               $claim0 = new Statement( new PropertyNoValueSnak( 42 ) );
                $claim0->setGuid( 'claim0' );
                $claim0->setRank( Claim::RANK_DEPRECATED );
 
-               $claim1 = new Statement( new \Wikibase\PropertyNoValueSnak( 42 
) );
+               $claim1 = new Statement( new PropertyNoValueSnak( 42 ) );
                $claim1->setGuid( 'claim1' );
                $claim1->setRank( Claim::RANK_DEPRECATED );
 
@@ -173,8 +178,6 @@
 
        /**
         * @dataProvider instanceProvider
-        *
-        * @param Statement $statement
         */
        public function testGetAllSnaks( Claim $claim ) {
                /* @var Statement $statement */

-- 
To view, visit https://gerrit.wikimedia.org/r/81948
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd71dc39fcb097bfc8ca1f6462e7fff5ca27e2be
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDataModel
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits