Matmarex has uploaded a new change for review. https://gerrit.wikimedia.org/r/82814
Change subject: jquery.suggestions: Do not duplicate keypress logic ...................................................................... jquery.suggestions: Do not duplicate keypress logic This is handled in keyup/keypress handlers, no need to repeat it twice. Change-Id: I3ddcd21136b44eedcec53b1ecc91bad38f697402 --- M resources/jquery/jquery.suggestions.js 1 file changed, 0 insertions(+), 16 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/14/82814/1 diff --git a/resources/jquery/jquery.suggestions.js b/resources/jquery/jquery.suggestions.js index bf38769..3c14a8e 100644 --- a/resources/jquery/jquery.suggestions.js +++ b/resources/jquery/jquery.suggestions.js @@ -577,22 +577,6 @@ // Store key pressed to handle later context.data.keypressed = e.which; context.data.keypressedCount = 0; - - switch ( context.data.keypressed ) { - // This preventDefault logic is duplicated from - // $.suggestions.keypress(), which sucks - case 40: // Arrow down - e.preventDefault(); - e.stopImmediatePropagation(); - break; - case 38: // Arrow up - case 27: // Escape - case 13: // Enter - if ( context.data.$container.is( ':visible' ) ) { - e.preventDefault(); - e.stopImmediatePropagation(); - } - } } ) .keypress( function ( e ) { context.data.keypressedCount++; -- To view, visit https://gerrit.wikimedia.org/r/82814 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3ddcd21136b44eedcec53b1ecc91bad38f697402 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits