jenkins-bot has submitted this change and it was merged. Change subject: Improvements to EntityPerPageBuilderTest. ......................................................................
Improvements to EntityPerPageBuilderTest. Change-Id: Ie97b7bbf0fa212041629473d01f1bfb97b140d7c --- M repo/tests/phpunit/includes/store/sql/EntityPerPageBuilderTest.php 1 file changed, 5 insertions(+), 21 deletions(-) Approvals: Daniel Kinzler: Looks good to me, approved jenkins-bot: Verified diff --git a/repo/tests/phpunit/includes/store/sql/EntityPerPageBuilderTest.php b/repo/tests/phpunit/includes/store/sql/EntityPerPageBuilderTest.php index 9b7b7b7..3f911af 100644 --- a/repo/tests/phpunit/includes/store/sql/EntityPerPageBuilderTest.php +++ b/repo/tests/phpunit/includes/store/sql/EntityPerPageBuilderTest.php @@ -1,29 +1,14 @@ <?php namespace Wikibase\Test; + use Wikibase\SettingsArray; use Wikibase\StoreFactory; use Wikibase\EntityPerPageBuilder; use Wikibase\Repo\WikibaseRepo; -use Wikibase\Lib\EntityIdParser; /** - * Tests for the Wikibase\EntityPerPageBuilder class. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html + * @covers Wikibase\EntityPerPageBuilder * * @file * @since 0.4 @@ -47,6 +32,9 @@ protected $entityPerPageRows; + /** + * @var WikibaseRepo + */ protected $wikibaseRepo; public function setUp() { @@ -87,10 +75,6 @@ protected function getTestSettings() { $settings = new SettingsArray( array( - 'entityPrefixes' => array( - 'q' => \Wikibase\Item::ENTITY_TYPE, - 'p' => \Wikibase\Property::ENTITY_TYPE - ), 'entityNamespaces' => array( 'wikibase-item' => 0, 'wikibase-property' => 102 -- To view, visit https://gerrit.wikimedia.org/r/81557 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie97b7bbf0fa212041629473d01f1bfb97b140d7c Gerrit-PatchSet: 8 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Addshore <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Tobias Gritschacher <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
