jenkins-bot has submitted this change and it was merged.
Change subject: Fix ridiculous MetaList test case
......................................................................
Fix ridiculous MetaList test case
Doing retainMetadata followed by a replace (not replaceMetadata)
doesn't make any sense and its behavior is undefined, so don't do that
in the test suite.
Change-Id: Ica032b0a5122d24e40e43e3eb43fea940270aece
---
M modules/ve/test/dm/ve.dm.MetaList.test.js
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/test/dm/ve.dm.MetaList.test.js
b/modules/ve/test/dm/ve.dm.MetaList.test.js
index 8463a89..cc8480d 100644
--- a/modules/ve/test/dm/ve.dm.MetaList.test.js
+++ b/modules/ve/test/dm/ve.dm.MetaList.test.js
@@ -106,7 +106,6 @@
[ 'pushRetain', 1 ],
[ 'pushReplaceMetadata', [
ve.dm.example.withMetaMetaData[9][0] ], [] ],
[ 'pushRetain', 2 ],
- [ 'pushRetainMetadata', 2 ],
// The two operations below have to be
in this order because of bug 46138
[ 'pushReplace', doc, 11, 0, [ {
'type': 'paragraph' }, 'a', 'b', 'c', { 'type': '/paragraph' } ] ],
[ 'pushReplaceMetadata', [], [ comment
] ]
@@ -123,7 +122,7 @@
for ( j = 0; j < cases[i].calls.length; j++ ) {
tx[cases[i].calls[j][0]].apply( tx,
cases[i].calls[j].slice( 1 ) );
}
- doc = ve.dm.example.createExampleDocument( 'withMeta' ),
+ doc = ve.dm.example.createExampleDocument( 'withMeta' );
surface = new ve.dm.Surface( doc );
list = new ve.dm.MetaList( surface );
// Test both the transaction-via-surface and
transaction-via-document flows
--
To view, visit https://gerrit.wikimedia.org/r/82785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica032b0a5122d24e40e43e3eb43fea940270aece
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
