EBernhardson (WMF) has submitted this change and it was merged. Change subject: Add a missing /*_*/ prefix on a CREATE INDEX ......................................................................
Add a missing /*_*/ prefix on a CREATE INDEX I don't know what it is, but this is the only CREATE INDEX missing it (untested random pattern-matching!). Also remove trailing whitespace. Bug: 54076 Change-Id: I21f9b3268cff68fd16e9187cf5263198cbb897be --- M flow.sql 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: EBernhardson (WMF): Verified; Looks good to me, approved diff --git a/flow.sql b/flow.sql index 75248cd..2cac549 100644 --- a/flow.sql +++ b/flow.sql @@ -6,10 +6,10 @@ definition_wiki varchar(32) binary NOT NULL, definition_name varchar(32) binary NOT NULL, definition_type varchar(32) binary NOT NULL, - definition_options BLOB NULL, -- should instead be revisioned blob + definition_options BLOB NULL, -- should instead be revisioned blob PRIMARY KEY (definition_id) ) /*$wgDBTableOptions*/; -CREATE UNIQUE INDEX /*i*/flow_definition_unique_name ON flow_definition (definition_wiki, definition_name); +CREATE UNIQUE INDEX /*i*/flow_definition_unique_name ON /*_*/flow_definition (definition_wiki, definition_name); CREATE TABLE /*_*/flow_workflow ( workflow_id binary(16) not null, @@ -66,13 +66,13 @@ PRIMARY KEY( tree_rev_id ) ) /*$wgDBTableOptions*/; -CREATE UNIQUE INDEX /*i*/flow_tree_descendant_id_revisions +CREATE UNIQUE INDEX /*i*/flow_tree_descendant_id_revisions ON /*_*/flow_tree_revision ( tree_rev_descendant_id, tree_rev_id ); -- Summary Content --- Instead of summary, should this be more generic 'revisioned scratchpad' +-- Instead of summary, should this be more generic 'revisioned scratchpad' -- or something? Main limit in current setup can only associate one summary per --- workflow +-- workflow CREATE TABLE /*_*/flow_summary_revision ( summary_workflow_id binary(16) not null, summary_rev_id binary(16) not null, -- To view, visit https://gerrit.wikimedia.org/r/84297 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21f9b3268cff68fd16e9187cf5263198cbb897be Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Spage <sp...@wikimedia.org> Gerrit-Reviewer: Bsitu <bs...@wikimedia.org> Gerrit-Reviewer: EBernhardson (WMF) <ebernhard...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits