Ottomata has submitted this change and it was merged.

Change subject: Unsubscribe elasticsearch from changes to config.
......................................................................


Unsubscribe elasticsearch from changes to config.

Elasticsearch is normally ok with restarts out of the blue but we don't
want to tempt fate so we'll be doing those restars manually.

Change-Id: Ideaff6540b9a870fd859b055892523e785be650d
---
M modules/elasticsearch/manifests/init.pp
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/elasticsearch/manifests/init.pp 
b/modules/elasticsearch/manifests/init.pp
index c8f497e..b4f4664 100644
--- a/modules/elasticsearch/manifests/init.pp
+++ b/modules/elasticsearch/manifests/init.pp
@@ -39,21 +39,18 @@
         ensure  => present,
         content => template('elasticsearch/elasticsearch.yml.erb'),
         mode    => '0444',
-        notify  => Service['elasticsearch'],
         require => Package['elasticsearch'],
     }
     file { '/etc/elasticsearch/logging.yml':
         ensure  => file,
         content => template('elasticsearch/logging.yml.erb'),
         mode    => '0444',
-        notify  => Service['elasticsearch'],
         require => Package['elasticsearch'],
     }
     file { '/etc/default/elasticsearch':
         ensure  => file,
         content => template('elasticsearch/elasticsearch.erb'),
         mode    => '0444',
-        notify  => Service['elasticsearch'],
         require => Package['elasticsearch'],
     }
     file { '/etc/logrotate.d/elasticsearch':
@@ -63,6 +60,9 @@
         mode    => '0444',
         source  => 'puppet:///modules/elasticsearch/logrotate',
     }
+    # Note that we don't notify the Elasticsearch service of changes to its
+    # config files because you need to be somewhat careful when restarting it.
+    # So, for now at least, we'll be restarting it manually.
 
     # Keep service running
     service { 'elasticsearch':

-- 
To view, visit https://gerrit.wikimedia.org/r/84982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ideaff6540b9a870fd859b055892523e785be650d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Manybubbles <[email protected]>
Gerrit-Reviewer: Manybubbles <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to