Cmcmahon has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/85006


Change subject: better checks for edit controls prevent false failures in IE in 
particular
......................................................................

better checks for edit controls prevent false failures in IE in particular

Change-Id: I1260fc1c1085c17c923df5a0c886a60992f184cc
---
M features/step_definitions/page_edit_steps.rb
1 file changed, 5 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/06/85006/1

diff --git a/features/step_definitions/page_edit_steps.rb 
b/features/step_definitions/page_edit_steps.rb
index 132c56c..d532cf2 100644
--- a/features/step_definitions/page_edit_steps.rb
+++ b/features/step_definitions/page_edit_steps.rb
@@ -15,12 +15,11 @@
     edit_page = EditPage
   end
   on(edit_page) do |page|
-    page.bold_element.should exist
-    page.italic_element.should exist
-    page.sig_element.should exist
-    page.link_element.should exist
-    page.embedded_element.should exist
-  end
+    page.bold_element.when_present.should be_visible
+    page.italic_element.when_present.should be_visible
+    page.sig_element.when_present.should be_visible
+    page.link_element.when_present.should be_visible
+    page.embedded_element.when_presentshould be_visible
 end
 Then(/^Edit controls should not be there$/) do
   on(EditPage) do |page|

-- 
To view, visit https://gerrit.wikimedia.org/r/85006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1260fc1c1085c17c923df5a0c886a60992f184cc
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to