Zfilipin has submitted this change and it was merged.
Change subject: better checks for edit controls prevent false failures in IE in
particular
......................................................................
better checks for edit controls prevent false failures in IE in particular
Change-Id: I1260fc1c1085c17c923df5a0c886a60992f184cc
---
M features/step_definitions/page_edit_steps.rb
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Zfilipin: Looks good to me, approved
jenkins-bot: Verified
diff --git a/features/step_definitions/page_edit_steps.rb
b/features/step_definitions/page_edit_steps.rb
index 132c56c..2ee4bfe 100644
--- a/features/step_definitions/page_edit_steps.rb
+++ b/features/step_definitions/page_edit_steps.rb
@@ -15,11 +15,11 @@
edit_page = EditPage
end
on(edit_page) do |page|
- page.bold_element.should exist
- page.italic_element.should exist
- page.sig_element.should exist
- page.link_element.should exist
- page.embedded_element.should exist
+ page.bold_element.when_present.should be_visible
+ page.italic_element.when_present.should be_visible
+ page.sig_element.when_present.should be_visible
+ page.link_element.when_present.should be_visible
+ page.embedded_element.when_presentshould be_visible
end
end
Then(/^Edit controls should not be there$/) do
--
To view, visit https://gerrit.wikimedia.org/r/85006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1260fc1c1085c17c923df5a0c886a60992f184cc
Gerrit-PatchSet: 2
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
