Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/88254
Change subject: Follow-up 99c92a87fc: Fix vector-animateLayout breakage
......................................................................
Follow-up 99c92a87fc: Fix vector-animateLayout breakage
* @arguments is not suitable here because it joins the arguments
by space instead of comma, thus outputting invalid CSS.
* Removed quotes from 'left 250ms' was producing invalid CSS.
* Quoted 'margin-left 250ms, padding 250ms' with the ~ operator
which instructs Less use the quotes to wrap the argument but
keeping them out of the actual value being passed.
Before 99c92a87fc:
transition: margin-left 250ms, padding 250ms
transition: left 250ms;
After 99c92a87fc:
transition: margin-left 250ms padding 250ms
transition: 'left 250ms';
Dev Tools / CSS errors:
Invalid CSS property value: margin-left 250ms padding 250ms
Invalid CSS property value: 'left 250ms'
Now:
transition: margin-left 250ms, padding 250ms
transition: left 250ms;
Change-Id: I80786c726a412d6b9e04c384112849e9587990b4
---
M resources/mediawiki.less/mediawiki.mixins.less
M skins/vector/screen.less
2 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/54/88254/1
diff --git a/resources/mediawiki.less/mediawiki.mixins.less
b/resources/mediawiki.less/mediawiki.mixins.less
index cca5af4..0433b02 100644
--- a/resources/mediawiki.less/mediawiki.mixins.less
+++ b/resources/mediawiki.less/mediawiki.mixins.less
@@ -38,9 +38,9 @@
list-style-image: url(@url);
}
-.transition( ... ) {
- -moz-transition: @arguments;
- -webkit-transition: @arguments;
- -o-transition: @arguments;
- transition: @arguments;
+.transition( @string ) {
+ -webkit-transition: @string;
+ -moz-transition: @string;
+ -o-transition: @string;
+ transition: @string;
}
diff --git a/skins/vector/screen.less b/skins/vector/screen.less
index e00bcef..42a31fb 100644
--- a/skins/vector/screen.less
+++ b/skins/vector/screen.less
@@ -783,10 +783,10 @@
div#content,
div#footer,
#left-navigation {
- .transition( margin-left 250ms, padding 250ms );
+ .transition( ~'margin-left 250ms, padding 250ms' );
}
#p-logo {
- .transition( 'left 250ms' );
+ .transition( left 250ms );
}
#mw-panel {
.transition( padding-right 250ms );
--
To view, visit https://gerrit.wikimedia.org/r/88254
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80786c726a412d6b9e04c384112849e9587990b4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
