jenkins-bot has submitted this change and it was merged.
Change subject: Make MWInlineImages resizable
......................................................................
Make MWInlineImages resizable
Because they are.
Change-Id: Ib2ff3ac6e9c5ed896486c93c48697d232b892493
---
M modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
1 file changed, 28 insertions(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
index 28d39d8..f7ed04d 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWInlineImageNode.js
@@ -13,6 +13,7 @@
* @mixins ve.ce.ProtectedNode
* @mixins ve.ce.FocusableNode
* @mixins ve.ce.RelocatableNode
+ * @mixins ve.ce.MWResizableNode
*
* @constructor
* @param {ve.dm.MWInlineImageNode} model Model to observe
@@ -39,6 +40,7 @@
ve.ce.ProtectedNode.call( this );
ve.ce.FocusableNode.call( this );
ve.ce.RelocatableNode.call( this );
+ ve.ce.MWResizableNode.call( this );
this.$image
.attr( 'src', this.model.getAttribute( 'src' ) )
@@ -68,12 +70,38 @@
ve.mixinClass( ve.ce.MWInlineImageNode, ve.ce.RelocatableNode );
+// Need to mixin base class as well
+ve.mixinClass( ve.ce.MWInlineImageNode, ve.ce.ResizableNode );
+
+ve.mixinClass( ve.ce.MWInlineImageNode, ve.ce.MWResizableNode );
+
/* Static Properties */
ve.ce.MWInlineImageNode.static.name = 'mwInlineImage';
ve.ce.MWInlineImageNode.static.tagName = 'img';
+/* Methods */
+
+/** */
+ve.ce.MWInlineImageNode.prototype.onAttributeChange = function ( key, from, to
) {
+ if ( key === 'height' || key === 'width' ) {
+ to = parseInt( to, 10 );
+ }
+
+ if ( from !== to ) {
+ switch ( key ) {
+ // TODO: 'align', 'src', 'valign', 'border'
+ case 'width':
+ this.$image.css( 'width', to );
+ break;
+ case 'height':
+ this.$image.css( 'height', to );
+ break;
+ }
+ }
+};
+
/* Registration */
ve.ce.nodeFactory.register( ve.ce.MWInlineImageNode );
--
To view, visit https://gerrit.wikimedia.org/r/88971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2ff3ac6e9c5ed896486c93c48697d232b892493
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
