jenkins-bot has submitted this change and it was merged.
Change subject: deleteEqualMessages: Exclude messages that are empty by default
......................................................................
deleteEqualMessages: Exclude messages that are empty by default
The main purpose of this script is to purge local overrides to
avoid them from blocking an i18n update in the future.
However empty messages should remain empty and often have a
richer edit history (e.g. Sitenotice) and may not stay empty
for long.
Change-Id: I5b416cda25a3641862df9919c46ae59ad5d5d6e0
---
M maintenance/deleteEqualMessages.php
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/deleteEqualMessages.php
b/maintenance/deleteEqualMessages.php
index 1e36363..8175891 100644
--- a/maintenance/deleteEqualMessages.php
+++ b/maintenance/deleteEqualMessages.php
@@ -70,7 +70,13 @@
$default = wfMessage( $key )->inLanguage(
$langCode )->useDatabase( false )->plain();
$messageInfo['relevantPages']++;
- if ( $actual === $default ) {
+
+ if (
+ // Exclude messages that are empty by
default, such as sitenotice, specialpage
+ // summaries and accesskeys.
+ $default !== '' && $default !== '-' &&
+ $actual === $default
+ ) {
$hasTalk = isset(
$statuses['talks'][$key] );
$messageInfo['results'][] = array(
'title' => $key . $titleSuffix,
--
To view, visit https://gerrit.wikimedia.org/r/88792
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b416cda25a3641862df9919c46ae59ad5d5d6e0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
