Hello Milimetric,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/91677

to review the following change.

Change subject: Fix basedir extraction for make&push script
......................................................................

Fix basedir extraction for make&push script

scripts/make_limn_files.py uses:
  -b -> --basename
  -d -> --basedir

Change-Id: If779808999db353e2ce58f14af4d45202b08ad7d
---
M scripts/make_and_push_limn_files.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/geowiki 
refs/changes/77/91677/1

diff --git a/scripts/make_and_push_limn_files.sh 
b/scripts/make_and_push_limn_files.sh
index 7d1c358..0634528 100755
--- a/scripts/make_and_push_limn_files.sh
+++ b/scripts/make_and_push_limn_files.sh
@@ -49,7 +49,7 @@
                        "$MAIN_SCRIPT_FILE_ABS" --help
                        exit 0
                        ;;
-               "--basedir="* | "-b="* )
+               "--basedir="* | "-d="* )
                        BASE_DIR_REL="${PARAM//*=/}"
                        ;;
        esac

-- 
To view, visit https://gerrit.wikimedia.org/r/91677
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If779808999db353e2ce58f14af4d45202b08ad7d
Gerrit-PatchSet: 1
Gerrit-Project: analytics/geowiki
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to