Werdna has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/92437


Change subject: Flow: Fix bug where URL was not updated in address bar when 
permalink icon was clicked
......................................................................

Flow: Fix bug where URL was not updated in address bar when permalink icon was 
clicked

Change-Id: I56f95763b625722cdef9734bcc4c283bfaab57e7
---
M modules/discussion/ui.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/37/92437/1

diff --git a/modules/discussion/ui.js b/modules/discussion/ui.js
index 703e771..a01c15a 100644
--- a/modules/discussion/ui.js
+++ b/modules/discussion/ui.js
@@ -290,9 +290,9 @@
                if ( window.location.hash ) {
                        highlightPost( $( '.flow-post' + window.location.hash ) 
);
                }
+
                // perform same highlighting to anchors within page for 
consistency
                $container.find( '.flow-icon-permalink' ).click( function( e ) {
-                       e.preventDefault();
                        highlightPost( $( this.hash ) );
                } );
        } );

-- 
To view, visit https://gerrit.wikimedia.org/r/92437
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I56f95763b625722cdef9734bcc4c283bfaab57e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Werdna <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to