jenkins-bot has submitted this change and it was merged.
Change subject: Flow: Fix bug where URL was not updated in address bar when
permalink icon was clicked
......................................................................
Flow: Fix bug where URL was not updated in address bar when permalink icon was
clicked
Change-Id: I56f95763b625722cdef9734bcc4c283bfaab57e7
---
M modules/discussion/ui.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Matthias Mullie: Looks good to me, but someone else must approve
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/discussion/ui.js b/modules/discussion/ui.js
index 703e771..a01c15a 100644
--- a/modules/discussion/ui.js
+++ b/modules/discussion/ui.js
@@ -290,9 +290,9 @@
if ( window.location.hash ) {
highlightPost( $( '.flow-post' + window.location.hash )
);
}
+
// perform same highlighting to anchors within page for
consistency
$container.find( '.flow-icon-permalink' ).click( function( e ) {
- e.preventDefault();
highlightPost( $( this.hash ) );
} );
} );
--
To view, visit https://gerrit.wikimedia.org/r/92437
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56f95763b625722cdef9734bcc4c283bfaab57e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Werdna <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
