Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/92785


Change subject: Remove hard dependency upon BetaFeatures
......................................................................

Remove hard dependency upon BetaFeatures

Change-Id: I8a239792407cba8daf823cd1c868d8d927156a13
---
M VectorBeta.hooks.php
1 file changed, 16 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VectorBeta 
refs/changes/85/92785/1

diff --git a/VectorBeta.hooks.php b/VectorBeta.hooks.php
index 58f0f9d..6573237 100644
--- a/VectorBeta.hooks.php
+++ b/VectorBeta.hooks.php
@@ -34,15 +34,25 @@
                return true;
        }
 
+       /**
+        * Handler for SkinVectorStyleModules
+        * @param Skin $skin
+        * @param array $modules
+        * @return bool
+        */
        static function skinVectorStyleModules( $skin, &$modules ) {
-               if ( BetaFeatures::isFeatureEnabled( $skin->getUser(), 
'betafeatures-vector-typography-update' ) ) {
-                       $index = array_search( 'skins.vector', $modules );
-                       if ( $index !== false ) {
-                               array_splice( $modules, $index, 1 );
-                       }
-                       $modules[] = 'skins.vector.beta';
+               if ( class_exists( 'BetaFeatures')
+                       && !BetaFeatures::isFeatureEnabled( $skin->getUser(), 
'betafeatures-vector-typography-update' )
+               ) {
+                       return true;
                }
 
+               $index = array_search( 'skins.vector', $modules );
+               if ( $index !== false ) {
+                       array_splice( $modules, $index, 1 );
+               }
+               $modules[] = 'skins.vector.beta';
+
                return true;
        }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/92785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a239792407cba8daf823cd1c868d8d927156a13
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VectorBeta
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to