Jdlrobson has submitted this change and it was merged.
Change subject: Remove hard dependency upon BetaFeatures
......................................................................
Remove hard dependency upon BetaFeatures
Change-Id: I8a239792407cba8daf823cd1c868d8d927156a13
---
M VectorBeta.hooks.php
1 file changed, 11 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Verified; Looks good to me, approved
diff --git a/VectorBeta.hooks.php b/VectorBeta.hooks.php
index 58f0f9d..340bb8b 100644
--- a/VectorBeta.hooks.php
+++ b/VectorBeta.hooks.php
@@ -34,15 +34,24 @@
return true;
}
+ /**
+ * Handler for SkinVectorStyleModules
+ * @param Skin $skin
+ * @param array $modules
+ * @return bool
+ */
static function skinVectorStyleModules( $skin, &$modules ) {
- if ( BetaFeatures::isFeatureEnabled( $skin->getUser(),
'betafeatures-vector-typography-update' ) ) {
+ if ( class_exists( 'BetaFeatures')
+ && BetaFeatures::isFeatureEnabled( $skin->getUser(),
'betafeatures-vector-typography-update' )
+ ) {
$index = array_search( 'skins.vector', $modules );
if ( $index !== false ) {
array_splice( $modules, $index, 1 );
}
$modules[] = 'skins.vector.beta';
+ } elseif ( !class_exists( 'BetaFeatures' ) ) {
+ wfDebugLog( 'VectorBeta', 'The BetaFeatures extension
is not installed' );
}
-
return true;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/92785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a239792407cba8daf823cd1c868d8d927156a13
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VectorBeta
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
