Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/92899
Change subject: mediawiki.inspect#dumpTable: fix broken FF workaround
......................................................................
mediawiki.inspect#dumpTable: fix broken FF workaround
In Ib45487d10, we changed to invocation of console#table from
'console.table( data )' to 'console.table.call( console.table, data)'
to force an exception on Firefox, which doesn't define console.table but
doesn't complain if you try to invoke it. But on some versions of Chromium,
invoking using Function.prototype#call to invoke console#table results in a
'TypeError: Illegal invocation' exception. Ugh.
Change-Id: Ib2252003f29586a47efb9ec534becc6396936b34
---
M resources/mediawiki/mediawiki.inspect.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/99/92899/1
diff --git a/resources/mediawiki/mediawiki.inspect.js
b/resources/mediawiki/mediawiki.inspect.js
index 454d1a4..daf8bb2 100644
--- a/resources/mediawiki/mediawiki.inspect.js
+++ b/resources/mediawiki/mediawiki.inspect.js
@@ -131,7 +131,8 @@
// Use Function.prototype#call to force an
exception on Firefox,
// which doesn't define console#table but
doesn't complain if you
// try to invoke it.
- console.table.call( console.table, data );
+ console.table.call;
+ console.table( data );
return;
} catch (e) {}
try {
--
To view, visit https://gerrit.wikimedia.org/r/92899
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2252003f29586a47efb9ec534becc6396936b34
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
